i18n lib change - use htmr to parse html inside json files #8585 #8592
Conversation
pettinarip
requested review from
samajammin,
wackerow,
corwintines,
minimalsm and
jmcook1186
as code owners
github-actions
bot
added
content 🖋️
pettinarip
changed the title
✅ ethereum-org-website-react-i18n deploy preview ready
|
|
The last build (triggered manually) was successful. https://www.gatsbyjs.com/dashboard/5e02f963-3fe5-4e37-a1e7-ac05f7753a86/sites/cd906ab6-d953-4705-ba62-6d4128ac2d8a/pull-requests/84607095-38e5-445a-b917-7942e45fa276/builds |
src/components/Translation.tsx
Outdated
| const transform = { | ||
| a: Link, | ||
| } | ||
|
|
||
| // Wrapper on <FormattedHTMLMessage /> to always fallback to English |
There was a problem hiding this comment.
Seems this explanation is now out of date (given we swapped i18n libs)? Does it still fallback to English?
There was a problem hiding this comment.
Correct. Yea, I'll update that comment. And yes, it fallback to English.
There was a problem hiding this comment.
I mean, in const { t } = useTranslation(), the t function is the one that fallback to English.
| id: string | ||
| } | ||
|
|
||
| const transform = { | ||
| a: Link, |
There was a problem hiding this comment.
Is this the only element we'd want a custom component for?
There was a problem hiding this comment.
So far I haven't seen any other html element on the translation files where we would want to use a custom React component.
pettinarip
force-pushed
the
i18n-parse-html-json
branch
from
6f95d97 to
45124c8
Compare
This PR removes the usage of
dangerouslySetInnerHTML(for security reasons) to insert html content from the translation files. Instead, it uses the htmr lib where we can also use our own custom components (similar to what we do with markdown files).Description
dangerouslySetInnerHTMLhtmrto parse the inner html that json files may haveRelated Issue
#8345